refactor: use internal FileEntry type#92
Merged
Conversation
cguedes
requested changes
Jun 5, 2023
cguedes
left a comment
cguedes
left a comment
Collaborator
There was a problem hiding this comment.
Just added a note about the dotfiles
cguedes
previously approved these changes
Jun 5, 2023
cguedes
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75
Problem
Our code should not rely on the tauri
FileEntrytype. Moreover, this type lacks some useful fields likeisFolderSolution
Create our own internal
FileEntrytype with a discriminating union. The tauri type should only appear in the interface (filesystem.ts), which then converts it to our internal type, which is used acrossed the rest of the app