Skip to content

Ensure main.spec exists before removing#87

Merged
gjreda merged 1 commit into
mainfrom
fix-remove_binary
Jun 5, 2023
Merged

Ensure main.spec exists before removing#87
gjreda merged 1 commit into
mainfrom
fix-remove_binary

Conversation

@cguedes

@cguedes cguedes commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator

Also don't remove all *.spec files bc we might be removing files we don't want

Also don't remove all *.spec files bc we might be removing files we don't wanty
@cguedes

cguedes commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator Author

CC @gjreda

@cguedes cguedes requested a review from sergioramos June 5, 2023 09:40
@hammer

hammer commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Is rm -f main.spec not preferred? I don't really care just curious if there's a reason to prefer the touch approach here...

@gjreda gjreda merged commit ea21196 into main Jun 5, 2023
@gjreda gjreda deleted the fix-remove_binary branch June 5, 2023 18:59
@cguedes

cguedes commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator Author

Is rm -f main.spec not preferred? I don't really care just curious if there's a reason to prefer the touch approach here...

@hammer the original code was using a wildcard rm *.spec that don't work with -f. We need to use rm -f "*.spec" if we use the *.

Now that we only remove the main.spec file we can use rm -f main.spec. Will add this fix to #99 (also related with scripts)

cguedes added a commit that referenced this pull request Jun 6, 2023
gjreda pushed a commit that referenced this pull request Jun 6, 2023
* fix: path in script to reset uploads

* Adopt `rm -f` to remove `main.spec`

#87 (comment)

---------

Co-authored-by: Mathis Pierron <[email protected]>
Co-authored-by: Carlos Guedes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants