chore: check typescript error on push#67
Merged
Merged
Conversation
danvk
reviewed
Jun 1, 2023
danvk
approved these changes
Jun 1, 2023
Collaborator
Author
|
@sergioramos this is ready to be merged. |
cguedes
added
enhancement
sergioramos
changed the title
sergioramos
pushed a commit
that referenced
this pull request
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new yarn command to check typescript errors.
This command/check was also added to the git push hook to ensure that we can't push code that don't compile.
Also updates the
yarn checkto include this check.Related to #24 and #10
@sehyod