feat: Add missing api response types#522
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 81.65% 81.68% +0.03%
==========================================
Files 213 215 +2
Lines 12098 12118 +20
Branches 1179 1179
==========================================
+ Hits 9879 9899 +20
Misses 2205 2205
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
gjreda
commented
Sep 8, 2023
cguedes
approved these changes
Sep 8, 2023
cguedes
left a comment
cguedes
left a comment
Collaborator
There was a problem hiding this comment.
This is ready to go 🚀
I will see what we can do for filesystem API output files in order to adopt the new api design Dan started.
yarn reset:storage after pulling main.
To help, I updated the reset script to backup the content of the folder user1 so that we can copy paste some files we might have there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #510
@cguedes the following endpoints are still showing up as
unknown:read_file_api_fs__project_id___filepath__get-- I suspect this has something to do with this endpoint returning fastapi'sFileResponserather than our own definition. I tried wrappingFileResponse, but no luck.head_file_api_fs__project_id___filepath__head-- doesn't return anythingshutdown_api_meta_shutdown_post-- doesn't return anything