fix: activate venv instead of using poetry run#518
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
=======================================
Coverage 81.65% 81.65%
=======================================
Files 213 213
Lines 12098 12098
Branches 1179 1179
=======================================
Hits 9879 9879
Misses 2205 2205
Partials 14 14 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
approved these changes
Sep 7, 2023
cguedes
approved these changes
Sep 7, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we had some issues with our cache and removing it fixed the failing CI.
To delete cache, you can go there. The one that had an issue here was
venv-Linux-..., the cache for poetry dependencies. We are also caching yarn (node-cache-Linux-yarn-...) and now poetry with this PR (poetry-cache-...)This PR is removing the unnecessary installation of pytest via pip (pytest is installed via poetry in setup-python)
This is also improving our CI by caching poetry so that python jobs now take half of the time they use to take:
Before the PR:
After the PR:
