chore: remove sidecar from client code#507
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 81.53% 81.45% -0.08%
==========================================
Files 203 202 -1
Lines 12161 12110 -51
Branches 1185 1181 -4
==========================================
- Hits 9915 9864 -51
Misses 2232 2232
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
sidecar.tsand also thetypes.ts(adoptingapi-types.tsinstead).Also renames the
ingestion.tstoreferencesAPI(also methods) to follow the API guideline of a references API and also the existingprojectsAPIin the client.This closes #503