Skip to content

fix: prevent panel from uncollapsing when sidebar is disabled#502

Merged
cguedes merged 1 commit into
mainfrom
486-explorer-open-with-no-project
Sep 6, 2023
Merged

fix: prevent panel from uncollapsing when sidebar is disabled#502
cguedes merged 1 commit into
mainfrom
486-explorer-open-with-no-project

Conversation

@sehyod

@sehyod sehyod commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

Problem
Resizable panels' layout is stored in local storage. When starting the app with sidebars uncollapsed, the library will force them to be uncollapsed, even if the sidebar should be disabled.

Screenshot 2023-09-06 at 12 42 30

Solution
Prevent the automatic uncollapse action performed by the library when the sidebar is disabled.

Screenshot 2023-09-06 at 12 43 33

Fixes #486

@sehyod sehyod requested a review from cguedes September 6, 2023 11:43
@codecov

codecov Bot commented Sep 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #502 (8d023c5) into main (6b06f42) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   80.79%   80.68%   -0.11%     
==========================================
  Files         202      202              
  Lines       12150    12166      +16     
  Branches     1173     1173              
==========================================
  Hits         9816     9816              
- Misses       2319     2335      +16     
  Partials       15       15              
Files Changed Coverage Δ
src/application/sidebar/LeftSidePanelWrapper.tsx 0.00% <0.00%> (ø)
src/application/sidebar/RightSidePanelWrapper.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cguedes cguedes merged commit 4bf89b7 into main Sep 6, 2023
@cguedes cguedes deleted the 486-explorer-open-with-no-project branch September 6, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explorer open when no project is open

2 participants