Skip to content

feat: export references behaviour for web (and desktop)#501

Merged
cguedes merged 2 commits into
mainfrom
456-export-references-behaviour-for-web
Sep 6, 2023
Merged

feat: export references behaviour for web (and desktop)#501
cguedes merged 2 commits into
mainfrom
456-export-references-behaviour-for-web

Conversation

@cguedes

@cguedes cguedes commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

This closes #456 by exporting the references (.bib) to the exports folder inside the project. It will also close and open the exported file to provide user feedback.

image

Note: We need to close and open the file because otherwise the editor content won't update.

@cguedes cguedes linked an issue Sep 6, 2023 that may be closed by this pull request
@cguedes cguedes requested a review from sehyod September 6, 2023 10:47
@codecov

codecov Bot commented Sep 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #501 (28e4950) into main (9f510f9) will increase coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 42.10%.

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   80.70%   80.83%   +0.12%     
==========================================
  Files         201      202       +1     
  Lines       12077    12142      +65     
  Branches     1165     1172       +7     
==========================================
+ Hits         9747     9815      +68     
+ Misses       2315     2312       -3     
  Partials       15       15              
Files Changed Coverage Δ
src/api/api.ts 20.00% <ø> (+0.11%) ⬆️
src/wrappers/tauri-api-stubs/path.ts 100.00% <ø> (ø)
src/wrappers/tauri-wrapper.ts 100.00% <ø> (ø)
src/wrappers/EventsListener.tsx 95.83% <41.66%> (-4.17%) ⬇️
src/io/filesystem.ts 91.25% <42.85%> (+4.63%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread src/io/filesystem.ts
import { notifyError } from '../notifications/notifications';
import { notifyError, notifyInfo } from '../notifications/notifications';
import { ReferenceItem } from '../types/ReferenceItem';
import { desktopDir, join, sep } from '../wrappers/tauri-wrapper';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cguedes cguedes merged commit fe07d1f into main Sep 6, 2023
@cguedes cguedes deleted the 456-export-references-behaviour-for-web branch September 6, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export References behaviour for web

2 participants