feat: add empty welcome view#500
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 80.70% 80.79% +0.08%
==========================================
Files 201 202 +1
Lines 12077 12150 +73
Branches 1165 1173 +8
==========================================
+ Hits 9747 9816 +69
- Misses 2315 2319 +4
Partials 15 15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
changed the title
cguedes
requested changes
Sep 6, 2023
cguedes
left a comment
cguedes
left a comment
Collaborator
There was a problem hiding this comment.
Added two notes about refresh of the projects atom and for the ProjectsList component
cguedes
approved these changes
Sep 6, 2023
cguedes
pushed a commit
that referenced
this pull request
Sep 6, 2023
This removes the left buttons in the empty welcome screen: This also removes the Tips&Tricks collapsible in the default view: Finally, this refreshes the allProjectsAtom after creating a sample project (this had been forgotten when implementing #500) * feat: update the welcome view * chore: remove unused export * fix: refresh allProjectsAtom after creating sample project * chore: improve type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the empty view for the welcome screen (when the user has no project)
This loads the list of projects in an atom during app startup, so that the list is already available when displaying the welcome view
Closes #499