Skip to content

feat: open project dialog for web (and desktop)#498

Merged
cguedes merged 9 commits into
mainfrom
447-open-project-dialog-for-web
Sep 6, 2023
Merged

feat: open project dialog for web (and desktop)#498
cguedes merged 9 commits into
mainfrom
447-open-project-dialog-for-web

Conversation

@cguedes

@cguedes cguedes commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

This closes #447

Adds a new modal to select the project from a list of projects.

image

This PR also:

  • Remove newProjectAtom and use openProjectAtom to both new and open actions.

@cguedes cguedes linked an issue Sep 6, 2023 that may be closed by this pull request
@codecov

codecov Bot commented Sep 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #498 (aa9ccb9) into main (6b06f42) will increase coverage by 0.61%.
Report is 2 commits behind head on main.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
+ Coverage   80.79%   81.40%   +0.61%     
==========================================
  Files         202      203       +1     
  Lines       12150    12157       +7     
  Branches     1173     1183      +10     
==========================================
+ Hits         9816     9897      +81     
+ Misses       2319     2246      -73     
+ Partials       15       14       -1     
Files Changed Coverage Δ
src/application/App.tsx 0.00% <0.00%> (ø)
src/application/views/WelcomeView.tsx 0.00% <0.00%> (ø)
src/application/listeners/projectEventListeners.ts 48.48% <45.45%> (+8.10%) ⬆️
src/application/CreateProjectModal.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/application/SelectProjectModal.tsx 100.00% <100.00%> (ø)
src/application/components/ProjectsList.tsx 100.00% <100.00%> (ø)
src/atoms/projectState.ts 84.72% <100.00%> (+11.78%) ⬆️
src/io/filesystem.ts 91.39% <100.00%> (+4.77%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes marked this pull request as ready for review September 6, 2023 11:01
Comment thread src/application/CreateProjectModal.tsx Outdated
Comment thread src/application/SelectProjectModal.tsx Outdated
Comment thread src/application/components/__tests__/ProjectsList.test.tsx Outdated
Comment thread src/application/views/WelcomeView.tsx

@sehyod sehyod left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these new tests!

@cguedes cguedes merged commit 32128d5 into main Sep 6, 2023
@cguedes cguedes deleted the 447-open-project-dialog-for-web branch September 6, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open Project Dialog for Web

2 participants