Reorg FastAPI backend into submodules#495
Conversation
|
@gjreda what do you think of removing the top level |
|
@cguedes I'd like to keep it (or rename it) in order to follow a fairly standard python project layout. |
|
@gjreda two notes before the review:
|
Codecov Report
@@ Coverage Diff @@
## main #495 +/- ##
==========================================
+ Coverage 81.52% 81.68% +0.16%
==========================================
Files 202 213 +11
Lines 12089 12109 +20
Branches 1181 1181
==========================================
+ Hits 9855 9891 +36
+ Misses 2220 2204 -16
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@cguedes I think this is good to go now. The codegen schemas look ok to me, but can you verify on your end as well? There aren't any tests for that code, so it was hard to verify that the changes were ok. I'll write some tests for |
- We forgot to update this in #495
* Fix the code that set logger enabled/disabled * Fix the Python: FastAPI launch script - We forgot to update this in #495
fixes #415
Break up the backend into submodules. This layout largely follows the FastAPI best practices listed here, which is inspired by Netflix's Dispatch project.
fc10954 also fixes #494. Threw it on here since it was going to lead to merge conflicts.