fix: margin between sibling list items#488
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 80.76% 80.78% +0.01%
==========================================
Files 198 198
Lines 11856 11864 +8
Branches 1141 1141
==========================================
+ Hits 9576 9584 +8
Misses 2266 2266
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Yes please! The Notion behavior is more natural to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 2 issues:
The first issue was a bug and has been fixed. The second one was more or less intended: the design specifies that there should be 24px between each node:
I have changed that to make collapsible nodes considered as list items (which makes sense because that is how we export them in markdown). However, the default spacing remains 24px, which means that turning a regular node into a collapsible node still results in things moving up and down:
Screen.Recording.2023-09-05.at.14.04.12.mov
On notion, the spacing is the same between every kind of node, except headings. So the question is do we want to do the same and remove this 24px spacing we have @hammer?
Fixes #481