Skip to content

feat: Add active project id to settings#476

Merged
cguedes merged 3 commits into
mainfrom
add-active_project_id-to-settings
Sep 4, 2023
Merged

feat: Add active project id to settings#476
cguedes merged 3 commits into
mainfrom
add-active_project_id-to-settings

Conversation

@gjreda

@gjreda gjreda commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator

fixes #445

@codecov

codecov Bot commented Sep 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #476 (99d0171) into main (b1c7433) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files         195      195           
  Lines       11660    11661    +1     
  Branches     1115     1115           
=======================================
+ Hits         9354     9355    +1     
  Misses       2290     2290           
  Partials       16       16           
Files Changed Coverage Δ
python/sidecar/settings.py 96.15% <ø> (ø)
python/sidecar/typing.py 98.01% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gjreda

gjreda commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator Author

cc @cguedes

@cguedes cguedes merged commit e4c57e6 into main Sep 4, 2023
@cguedes cguedes deleted the add-active_project_id-to-settings branch September 4, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update settings to adopt project ID instead of project path

2 participants