feat: update styles of rewrite panel#463
Merged
Merged
Conversation
added 14 commits
August 24, 2023 11:09
Codecov Report
@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 79.14% 79.81% +0.66%
==========================================
Files 191 194 +3
Lines 11322 11663 +341
Branches 1081 1110 +29
==========================================
+ Hits 8961 9309 +348
+ Misses 2344 2338 -6
+ Partials 17 16 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
requested changes
Sep 1, 2023
cguedes
left a comment
cguedes
left a comment
Collaborator
There was a problem hiding this comment.
Some notes:
-
We should keep the heading "Pick Variation ..." fixed and only scroll the choice
-
I did expected an animation for when switching between variations
-
The sider bg %age is incorrectly computed for this scenario
-
we should have a better text for this popup. Ask Jeff in slack.
-
Create a ticket to implement the rewrite inside the command palette
Collaborator
Author
|
Thank you for your comments.
|
added 5 commits
September 1, 2023 14:22
Collaborator
Author
|
I have updated the tooltip and the design team confirmed there should not be an animation when switching between variations @cguedes |
cguedes
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the styles of the Rewrite Panel
Screen.Recording.2023-08-31.at.17.06.55.mov
Closes #375