Skip to content

bug: Handle exception if a user tries to view references before any have been ingested#459

Merged
cguedes merged 4 commits into
mainfrom
444-gracefully-handle-filenotfound-exception-if-a-user-tries-to-view-references-before-any-have-been-ingested
Aug 31, 2023
Merged

bug: Handle exception if a user tries to view references before any have been ingested#459
cguedes merged 4 commits into
mainfrom
444-gracefully-handle-filenotfound-exception-if-a-user-tries-to-view-references-before-any-have-been-ingested

Conversation

@gjreda

@gjreda gjreda commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator

fixes #444

@gjreda gjreda requested a review from cguedes August 30, 2023 22:04
@codecov

codecov Bot commented Aug 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #459 (daae1db) into main (7d005cd) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   78.32%   78.38%   +0.06%     
==========================================
  Files         186      186              
  Lines       11160    11155       -5     
  Branches     1061     1061              
==========================================
+ Hits         8741     8744       +3     
+ Misses       2404     2396       -8     
  Partials       15       15              
Files Changed Coverage Δ
python/sidecar/storage.py 84.26% <ø> (-1.30%) ⬇️
python/sidecar/http.py 81.56% <100.00%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes merged commit 24e7cc9 into main Aug 31, 2023
@cguedes cguedes deleted the 444-gracefully-handle-filenotfound-exception-if-a-user-tries-to-view-references-before-any-have-been-ingested branch August 31, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gracefully handle FileNotFound exception if a user tries to view references before any have been ingested

2 participants