feat: Improve project details API#458
Merged
gjreda merged 17 commits intoSep 1, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 79.94% 80.22% +0.27%
==========================================
Files 195 195
Lines 11672 11660 -12
Branches 1115 1115
==========================================
+ Hits 9331 9354 +23
+ Misses 2325 2290 -35
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
danvk
reviewed
Aug 31, 2023
…on-tauri-fs-types-backend
danvk
previously requested changes
Aug 31, 2023
danvk
left a comment
danvk
left a comment
Collaborator
There was a problem hiding this comment.
Could you merge in the latest changes on main so we could see how this looks in the new api-paths.ts file?
I had questions about how we want to handle nested directories and the test.
cguedes
requested changes
Aug 31, 2023
…on-tauri-fs-types-backend
cguedes
requested changes
Sep 1, 2023
…on-tauri-fs-types-backend
cguedes
approved these changes
Sep 1, 2023
gjreda
dismissed
danvk’s stale review
today's not a day Dan works on this project
Collaborator
Author
|
That dismissal sounds more curt than I intended. I also addressed @danvk's comments in my changes 😅 |
gjreda
deleted the
448-improve-projects-api-and-stop-depending-on-tauri-fs-types-backend
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend fixes #448