Remove legacy sidecar CLI and HTTP methods#442
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 77.78% 78.09% +0.31%
==========================================
Files 188 188
Lines 11527 11481 -46
Branches 1116 1116
==========================================
Hits 8966 8966
+ Misses 2546 2500 -46
Partials 15 15
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gjreda
commented
Aug 29, 2023
| @@ -20,46 +20,55 @@ export type Detail = ValidationError[]; | |||
| * An enumeration. | |||
Collaborator
Author
There was a problem hiding this comment.
I'm not sure why codegen changed this file, but from what I can tell the changes are just the order in which things are defined in the file.
Collaborator
There was a problem hiding this comment.
I've seen this before. It's a bit anoying.
cguedes
approved these changes
Aug 30, 2023
| @@ -20,46 +20,55 @@ export type Detail = ValidationError[]; | |||
| * An enumeration. | |||
Collaborator
There was a problem hiding this comment.
I've seen this before. It's a bit anoying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #411 and fixes #427