Skip to content

feat: Add dependency on settings for AI endpoints#434

Merged
cguedes merged 5 commits into
mainfrom
430-add-utility-function-for-dev-only-so-that-local-env-settings-get-picked-up-on-app-startup-for-testing-ai-endpoints
Aug 29, 2023
Merged

feat: Add dependency on settings for AI endpoints#434
cguedes merged 5 commits into
mainfrom
430-add-utility-function-for-dev-only-so-that-local-env-settings-get-picked-up-on-app-startup-for-testing-ai-endpoints

Conversation

@gjreda

@gjreda gjreda commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator

fixes #429

@gjreda gjreda changed the title 430 add utility function for dev only so that local env settings get picked up on app startup for testing ai endpoints Add dependency on settings for AI endpoints Aug 28, 2023
@gjreda gjreda changed the title Add dependency on settings for AI endpoints feat: Add dependency on settings for AI endpoints Aug 28, 2023
@codecov

codecov Bot commented Aug 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #434 (f6e564b) into main (5d3e1c5) will decrease coverage by 0.05%.
The diff coverage is 69.44%.

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   77.69%   77.64%   -0.05%     
==========================================
  Files         190      190              
  Lines       11570    11590      +20     
  Branches     1115     1115              
==========================================
+ Hits         8989     8999      +10     
- Misses       2565     2575      +10     
  Partials       16       16              
Files Changed Coverage Δ
python/sidecar/http.py 80.00% <58.33%> (-1.29%) ⬇️
python/sidecar/rewrite.py 88.88% <71.42%> (-4.87%) ⬇️
python/sidecar/chat.py 86.56% <80.00%> (-2.50%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gjreda gjreda marked this pull request as ready for review August 29, 2023 01:32
@gjreda gjreda requested a review from cguedes August 29, 2023 01:32
@cguedes cguedes merged commit 1c9b54d into main Aug 29, 2023
@cguedes cguedes deleted the 430-add-utility-function-for-dev-only-so-that-local-env-settings-get-picked-up-on-app-startup-for-testing-ai-endpoints branch August 29, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend reads from settings on server and reimplements /ai functions (accept project id for future proofing)

2 participants