Add api for search#432
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 77.70% 77.69% -0.02%
==========================================
Files 190 190
Lines 11564 11570 +6
Branches 1115 1115
==========================================
+ Hits 8986 8989 +3
- Misses 2562 2565 +3
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
approved these changes
Aug 28, 2023
cguedes
left a comment
cguedes
left a comment
Collaborator
There was a problem hiding this comment.
All good. Just a comment about the name parameter.
| api.mount("/api/projects", http.project_api) | ||
| api.mount("/api/meta", http.meta_api) | ||
| api.mount("/api/settings", http.settings_api) | ||
| api.mount("/api/sidecar", http.sidecar_api, name="sidecar") |
Collaborator
Author
There was a problem hiding this comment.
Starlette optionally uses it for some stuff under the hood. I thought it might show up in the logs, but alas it doesn't.
Anyway, I just decided to leave it for now as I suspect it might be handy later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #428