Universal desktop web codebase#425
Merged
Merged
Conversation
- return project name - ensure storage folder (and references.json) exists - always create directory for new projects - support return project files for desktop
Codecov Report
@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 77.78% 77.94% +0.16%
==========================================
Files 188 186 -2
Lines 11527 11206 -321
Branches 1116 1061 -55
==========================================
- Hits 8966 8735 -231
+ Misses 2546 2456 -90
Partials 15 15
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- This will check check if the file exists in the project
- Remove dependency on tauri/fs APIs - Adopt HEAD in project filesystem to check if file exists - Add (initial) support to the SAMPLE project
sehyod
previously requested changes
Aug 29, 2023
- set project path for the sample project
4 tasks
This was referenced Aug 30, 2023
cguedes
changed the title
danvk
previously approved these changes
Aug 30, 2023
gjreda
previously approved these changes
Aug 30, 2023
This was referenced Aug 30, 2023
cguedes
dismissed
sehyod’s stale review
I've made all the changes. You need to review again.
cguedes
commented
Aug 30, 2023
cguedes
left a comment
cguedes
left a comment
Collaborator
Author
There was a problem hiding this comment.
Replied to all comments.
danvk
approved these changes
Aug 30, 2023
danvk
left a comment
danvk
left a comment
Collaborator
There was a problem hiding this comment.
Very excited to get this in!
3 tasks
This was referenced Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #422 by removing the if/else conditions using
import.meta.env.VITE_IS_WEBto implement a different code path between the desktop and web applications.Changes:
.staging/references.jsonand the project folder)/api/fs/...(for file exists)file upload don't work) 🎉Follow-up: