Skip to content

feat: add thinking animation#423

Merged
cguedes merged 4 commits into
mainfrom
420-add-thinking-animation
Aug 25, 2023
Merged

feat: add thinking animation#423
cguedes merged 4 commits into
mainfrom
420-add-thinking-animation

Conversation

@sehyod

@sehyod sehyod commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

This adds a thinking animation for the chatbot
I added vitest-canvas-mock because tests trying to render lottie files were crashing otherwise (cf. felippenardi/lottie-react-web#21)

Screen.Recording.2023-08-25.at.15.13.48.mov

Closes #420

@sehyod sehyod requested a review from cguedes August 25, 2023 14:30
@cguedes

cguedes commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

@sehyod do you think we can also use this animation for the text editor?

@sehyod

sehyod commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator Author

@sehyod do you think we can also use this animation for the text editor?

Do you mean for the sentence completion? If so, it is possible but trickier because the sentence completion is a prosemirror plugin so the node is pure HTML, not React. But we could create a node and then use createPortal

@cguedes

cguedes commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Yes, there. Ok.

@cguedes cguedes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad on how easy was to add Lottie 👏

@cguedes cguedes merged commit 3db59ee into main Aug 25, 2023
@cguedes cguedes deleted the 420-add-thinking-animation branch August 25, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chatbot thinking animation

2 participants