Conversation
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 80.90% 82.75% +1.85%
==========================================
Files 188 184 -4
Lines 11216 10840 -376
Branches 1141 1144 +3
==========================================
- Hits 9074 8971 -103
+ Misses 2127 1854 -273
Partials 15 15
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
previously approved these changes
Aug 25, 2023
| "editor.formatOnSave": false, | ||
| "editor.defaultFormatter": "ms-python.python", | ||
| "editor.codeActionsOnSave": [] | ||
| "editor.rulers": [88], |
|
|
||
| [tool.ruff] | ||
| line-length = 120 # same length we have prettier/JS set to | ||
| line-length = 88 # black default |
Collaborator
There was a problem hiding this comment.
I see now that 88 is black default. For the web we adopted 120 instead of the default 80.
Collaborator
Author
There was a problem hiding this comment.
88 has become the defacto python default thanks to black adoption. previously it was 79.
cguedes
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #416
Except for changes to the workspace .vscode/settings.json and .husky, this PR is entirely formatting changes.