Skip to content

fix: address comments from design#410

Merged
cguedes merged 2 commits into
mainfrom
409-address-feedback-from-design
Aug 24, 2023
Merged

fix: address comments from design#410
cguedes merged 2 commits into
mainfrom
409-address-feedback-from-design

Conversation

@sehyod

@sehyod sehyod commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

This makes the resize handles for sidebars transparent (only visible when hovering them)

Screen.Recording.2023-08-24.at.11.56.32.mov

This also replaces the icons for close button and unsaved changes circle to use custom icons created by the design team

Screenshot 2023-08-24 at 11 57 02 Screenshot 2023-08-24 at 11 57 12

Fixes #409

@sehyod sehyod requested a review from cguedes August 24, 2023 10:57
@sehyod sehyod changed the title fix: address feedback from design fix: address comments from design Aug 24, 2023
@codecov

codecov Bot commented Aug 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #410 (734d95d) into main (4473b60) will decrease coverage by 0.02%.
The diff coverage is 61.36%.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   83.15%   83.13%   -0.02%     
==========================================
  Files         182      182              
  Lines       10588    10614      +26     
  Branches     1128     1129       +1     
==========================================
+ Hits         8804     8824      +20     
- Misses       1768     1775       +7     
+ Partials       16       15       -1     
Files Changed Coverage Δ
src/application/sidebar/LeftSidePanelWrapper.tsx 0.00% <0.00%> (ø)
src/application/sidebar/RightSidePanelWrapper.tsx 0.00% <0.00%> (ø)
src/components/VerticalResizeHandle.tsx 0.00% <0.00%> (ø)
src/components/TabCloseButton.tsx 100.00% <100.00%> (ø)
src/components/icons.tsx 65.51% <100.00%> (+65.51%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes merged commit fbe91c9 into main Aug 24, 2023
@cguedes cguedes deleted the 409-address-feedback-from-design branch August 24, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style issues

2 participants