feat: design for main panel#404
Conversation
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 82.92% 83.15% +0.22%
==========================================
Files 180 182 +2
Lines 10408 10588 +180
Branches 1114 1128 +14
==========================================
+ Hits 8631 8804 +173
- Misses 1762 1768 +6
- Partials 15 16 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| text: editorData.title, | ||
| value: editorData.id, | ||
| isDirty: editorData.isDirty, | ||
| Icon: type === 'refstudio' ? <RefStudioEditorIcon /> : undefined, |
There was a problem hiding this comment.
@sehyod can we have icons for at least PDFs? (please ask the design team)
| className={cx('block', 'group-hover/tab-close-button:!block', { | ||
| '!hidden': isDirty, | ||
| })} | ||
| color="currentcolor" |
There was a problem hiding this comment.
Why do we need this? Where have you seen this documentation?
There was a problem hiding this comment.
We need it to be able to set the color in the parent div, in TabItem. That's just a regular CSS keyword: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#currentcolor_keyword
|
|
||
| .tiptap-editor span.selected { | ||
| background-color: #c4dcf6; | ||
| @apply bg-[#c4dcf6]; |
There was a problem hiding this comment.
Another color to maybe as the design team for a name, right?
There was a problem hiding this comment.
Yes! I will move it to a variable and ask the design team for which color we should use
2 participants
This updates the styles for the main panel, which includes the split bar and the tabs on the top.
This also updates the styles of the RefStudio editor: the menu bar and the text styles inside the editor itself
Before:
After:
Closes #370