chore: update tailwind color names#401
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 82.94% 82.92% -0.03%
==========================================
Files 180 180
Lines 10409 10408 -1
Branches 1114 1114
==========================================
- Hits 8634 8631 -3
- Misses 1760 1762 +2
Partials 15 15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
approved these changes
Aug 23, 2023
cguedes
left a comment
Collaborator
There was a problem hiding this comment.
nit: just left a note about some code (color definitions) we might remove.
Comment on lines
18
to
19
| muted: 'hsl(var(--color-muted) / <alpha-value>)', | ||
| error: 'hsl(var(--color-error) / <alpha-value>)', |
Collaborator
There was a problem hiding this comment.
We should maybe remove these.
Collaborator
Author
There was a problem hiding this comment.
We are still using them for sentence completion suggestions. Let's keep them for now, and we will remove them when we update the autocomplete design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates all tailwind color names, using this json file of exported tokensvariables.json.zip
I wrote small scripts to convert them. I don't think it's worth pushing them but I'll add them here for visibility:
Closes #400