Skip to content

chore: update codecov config#398

Merged
cguedes merged 1 commit into
mainfrom
update-codecov-config
Aug 23, 2023
Merged

chore: update codecov config#398
cguedes merged 1 commit into
mainfrom
update-codecov-config

Conversation

@sehyod

@sehyod sehyod commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

Closes #397

Comment thread codecov.yml
project:
default:
target: auto
threshold: 2% # allow for 2% reduction of coverage without failing

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to discuss this. I have noticed it's not rare for the coverage to decrease a bit during PRs, and we ignore it most of the time

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting is great IMO. Didn't knew they have such feature. I'm ok merging this change.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'm removing the draft status then
Ideally I wanted to set up a minimum target percentage, because with the config of this PR we could technically keep decreasing the coverage with several PRs until we reach low values. But I haven't found any option to do so

@codecov

codecov Bot commented Aug 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #398 (762022e) into main (1c15395) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files         178      178           
  Lines       10282    10282           
  Branches     1108     1108           
=======================================
  Hits         8560     8560           
  Misses       1708     1708           
  Partials       14       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod marked this pull request as ready for review August 23, 2023 09:03
@cguedes cguedes merged commit e06f8cd into main Aug 23, 2023
@cguedes cguedes deleted the update-codecov-config branch August 23, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update codecov configuration

2 participants