feat: Create python http equivalent of settingsManager.ts#396
Merged
cguedes merged 5 commits intoAug 24, 2023
Conversation
gjreda
changed the title
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 83.25% 83.00% -0.25%
==========================================
Files 178 180 +2
Lines 10282 10462 +180
Branches 1108 1114 +6
==========================================
+ Hits 8560 8684 +124
- Misses 1708 1763 +55
- Partials 14 15 +1
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
requested changes
Aug 23, 2023
cguedes
approved these changes
Aug 24, 2023
cguedes
deleted the
364-create-pythonhttp-equivalent-of-settingsmanagerts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #364
I think this generic API for settings should be all we need, but let me know otherwise @cguedes @danvk