Skip to content

Separate cli interprocess comms from functionality#394

Merged
gjreda merged 2 commits into
mainfrom
367-separate-cli-interprocess-comms-from-functionality
Aug 22, 2023
Merged

Separate cli interprocess comms from functionality#394
gjreda merged 2 commits into
mainfrom
367-separate-cli-interprocess-comms-from-functionality

Conversation

@gjreda

@gjreda gjreda commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

fixes #367

@gjreda gjreda marked this pull request as ready for review August 22, 2023 18:17
@gjreda gjreda requested review from cguedes and shauryr August 22, 2023 18:17
@codecov

codecov Bot commented Aug 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #394 (6c75371) into main (ba3c6f3) will decrease coverage by 0.10%.
The diff coverage is 17.39%.

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   83.34%   83.25%   -0.10%     
==========================================
  Files         178      178              
  Lines       10288    10282       -6     
  Branches     1108     1108              
==========================================
- Hits         8575     8560      -15     
- Misses       1699     1708       +9     
  Partials       14       14              
Files Changed Coverage Δ
python/main.py 0.00% <0.00%> (ø)
python/sidecar/chat.py 93.33% <ø> (-0.32%) ⬇️
python/sidecar/rewrite.py 93.75% <ø> (-0.46%) ⬇️
python/sidecar/search.py 48.57% <ø> (-2.78%) ⬇️
python/sidecar/ingest.py 90.03% <100.00%> (+0.33%) ⬆️
python/sidecar/storage.py 97.56% <100.00%> (-0.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gjreda gjreda requested a review from danvk August 22, 2023 18:18
@gjreda gjreda merged commit 1c15395 into main Aug 22, 2023
@gjreda gjreda deleted the 367-separate-cli-interprocess-comms-from-functionality branch August 22, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate CLI interprocess comms from functionality

2 participants