feat: Add python tests script and run python tests in pre-push#390
Conversation
cguedes
changed the title
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 83.89% 87.09% +3.19%
==========================================
Files 159 17 -142
Lines 9099 1046 -8053
Branches 1101 0 -1101
==========================================
- Hits 7634 911 -6723
+ Misses 1454 135 -1319
+ Partials 11 0 -11
... and 175 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@cguedes The tests started to fail when you pushed this commit to the PR: f026603 I'll push a fix, but they were failing before merging into main. The root cause is that you changed the filename for projects storage, but did not update the tests. |
|
I suspect the bigger bug here is in our merge process: since we have historically ignored when codecov/patch is failing, I'm going to guess we simply thought it was codecov/patch that led to the ❌ on the PR, and not that actual tests were failing. I know I've been guilty of this in the past too, so we should probably figure out how to make codecov/patch work as we'd like or simply get rid of it, since we do not trust it. |
You are right. I thought it was again the codecov/patch issue. |
Yes, I 100% agree! codecov/patch is not super useful anyway, the most important is codecov/project |
3 participants
@gjreda I've just noticed that the #389 is failing in the CI after merge agains main!
This PR adds an utility to run python tests from the project root using yarn
yarn python:testsand updates the git push hook to also run python tests.@gjreda please fix the error reported in #391 (I don't know how 😅).
fixes #391