feat: update sidebar design#383
Merged
Merged
Conversation
added 8 commits
August 18, 2023 12:46
Codecov Report
@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 84.16% 83.09% -1.08%
==========================================
Files 175 161 -14
Lines 10016 9192 -824
Branches 1101 1106 +5
==========================================
- Hits 8430 7638 -792
+ Misses 1575 1540 -35
- Partials 11 14 +3
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
commented
Aug 22, 2023
cguedes
requested changes
Aug 22, 2023
cguedes
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a generic Sidebar component, uses it for the left sidebar, and replaces the right panel logic with a second sidebar on the right
This also fixes the background of the splashscreen to be the same as the one of the welcome screen, instead of white
NB: This PR does not update the sidebar panels (like the references panel, the file explorer panel, etc.)
Closes #371