feat: web call sidecar http#382
Merged
Merged
Conversation
Note: I've had to change this bc I was getting an error like:
```
response = sidecar.ingest.get_statuses()
^^^^^^^^^^^^^^
AttributeError: module 'sidecar' has no attribute 'ingest'
```
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 84.25% 84.10% -0.16%
==========================================
Files 174 174
Lines 9946 9964 +18
Branches 1097 1097
==========================================
Hits 8380 8380
- Misses 1555 1573 +18
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
commented
Aug 18, 2023
gjreda
reviewed
Aug 18, 2023
gjreda
reviewed
Aug 18, 2023
gjreda
reviewed
Aug 18, 2023
- Update HTTP api interface - Update format save rules for python
cguedes
commented
Aug 21, 2023
| "editor.formatOnSave": true | ||
| }, | ||
| "[python]": { | ||
| "editor.formatOnSave": false, |
Collaborator
Author
There was a problem hiding this comment.
@gjreda added this configurations to prevent VSCode from automatically format the python code with prettier.
Let me know what is the code formatter we should use and I can configure it instead of "ms-python.python".
sehyod
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #380 that allows the web application to call the sidecar commands via HTTP interface.
Also adds utility startup scripts and updates README.md