fix: make indent commands return proper command result#343
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 86.35% 86.28% -0.07%
==========================================
Files 150 150
Lines 8491 8497 +6
Branches 957 957
==========================================
Hits 7332 7332
- Misses 1148 1154 +6
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
indentandunindentcommands were returningtrueto block default behavior ofTabandShift-Tabshortcuts. However this made theBackspacecommand believe that the content could be unindented, blocking the fallback behavior of the shortcut, which is merging the line with the previous one.Solution
This changes the return result of
indentandunindentcommands back to the proper boolean indicating whether the command can run.TabandShift-Tabshortcuts are now the one responsible for returningtrueto block the default behavior of these shortcuts.Fixes #342