Skip to content

chore: add ruff for Python linting#34

Merged
sergioramos merged 4 commits into
mainfrom
gjreda/ruff
May 26, 2023
Merged

chore: add ruff for Python linting#34
sergioramos merged 4 commits into
mainfrom
gjreda/ruff

Conversation

@gjreda

@gjreda gjreda commented May 24, 2023

Copy link
Copy Markdown
Collaborator

Adding ruff with its default settings as a pre-push hook for now. I imagine we'll want to tweak some settings later (like line length).

Once this is merged, devs will need to run:

$ poetry install

@cguedes cguedes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjreda Does it make sense add package.json scripts for check and fix like we did for eslint and prettier?

You can check #37 for what I've implemented for prettier.

@gjreda gjreda requested a review from cguedes May 25, 2023 17:18
@gjreda

gjreda commented May 25, 2023

Copy link
Copy Markdown
Collaborator Author

@cguedes should be good now

@cguedes cguedes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@sergioramos sergioramos changed the title chore: Add ruff for Python linting chore: add ruff for Python linting May 26, 2023
@sergioramos sergioramos merged commit f522e15 into main May 26, 2023
@sergioramos sergioramos deleted the gjreda/ruff branch May 26, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants