Skip to content

doi extraction for linking to external databases#338

Merged
shauryr merged 3 commits into
mainfrom
140-doi-extraction-for-linking
Aug 1, 2023
Merged

doi extraction for linking to external databases#338
shauryr merged 3 commits into
mainfrom
140-doi-extraction-for-linking

Conversation

@shauryr

@shauryr shauryr commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

Adds doi field from grobid extraction to the references.json. For most papers this can be used to link to other databases mentioned in #140

@shauryr shauryr requested review from cguedes, danvk and hammer July 30, 2023 01:22
@shauryr shauryr changed the title 140 doi extraction for linking to external databases doi extraction for linking to external databases Jul 30, 2023
@codecov

codecov Bot commented Jul 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #338 (bb76cb7) into main (adc02a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files         150      150           
  Lines        8487     8488    +1     
  Branches      957      957           
=======================================
+ Hits         7329     7330    +1     
  Misses       1147     1147           
  Partials       11       11           
Files Changed Coverage Δ
python/sidecar/ingest.py 90.37% <ø> (ø)
python/sidecar/typing.py 97.26% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shauryr shauryr requested review from gjreda and removed request for danvk August 1, 2023 14:52
@gjreda

gjreda commented Aug 1, 2023

Copy link
Copy Markdown
Collaborator

@shauryr Is this coming from grobid?

Can you also create a corresponding issue so that this is added to the UI as well? I imagine we'll want to make this field editable by the user in situations where we do not have the DOI, but the user would like to provide it.

@shauryr

shauryr commented Aug 1, 2023

Copy link
Copy Markdown
Collaborator Author

@gjreda yes this is coming from grobid.
Making the doi editable is a great suggestion! I will create an issue regarding this. Thank you!

@shauryr shauryr merged commit 9b2b7cf into main Aug 1, 2023
@shauryr shauryr deleted the 140-doi-extraction-for-linking branch August 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants