Skip to content

feat: update readme with demo gif and information about project#304

Merged
cguedes merged 14 commits into
mainfrom
160-update-readme-with-demo-gif-and-information-about-project
Jul 17, 2023
Merged

feat: update readme with demo gif and information about project#304
cguedes merged 14 commits into
mainfrom
160-update-readme-with-demo-gif-and-information-about-project

Conversation

@cguedes

@cguedes cguedes commented Jul 14, 2023

Copy link
Copy Markdown
Collaborator

This closes #160

The PR adds:

  • Information about the project
  • Badges (for CI and code coverage)
  • Remove $ in bash scripts
  • New section with prerequisites and rewrite of setup section

The new README is available here.

cguedes added 3 commits July 14, 2023 09:49
- Sample image (will upgraded to a GIF)
- Adds a section with Prerequisites
- rewrite setup & run section
@cguedes cguedes linked an issue Jul 14, 2023 that may be closed by this pull request
@cguedes cguedes marked this pull request as draft July 14, 2023 09:16
@hammer

hammer commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

Thanks, this looks good as a definite improvement! I can tweak the text a bit after it goes in.

I also think we need to include Rust in the prerequisites. Maybe something like:

  • JavaScript: node.js (>= 18.12.0 LTS) and Yarn package manager
  • Python: and Poetry package manager
  • Rust: and Cargo package manager

@codecov

codecov Bot commented Jul 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #304 (f3db0a1) into main (0094734) will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   86.33%   87.60%   +1.27%     
==========================================
  Files         135       12     -123     
  Lines        7528      799    -6729     
  Branches      823        0     -823     
==========================================
- Hits         6499      700    -5799     
+ Misses       1016       99     -917     
+ Partials       13        0      -13     

see 123 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hammer

hammer commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

Good to merge?

@cguedes

cguedes commented Jul 14, 2023

Copy link
Copy Markdown
Collaborator Author

I’m trying to get a short GIF now that we have the completion command merged. But we can merge this and I can create another PR only for that.

@cguedes cguedes marked this pull request as ready for review July 17, 2023 10:44
Comment thread README.md
@cguedes cguedes merged commit 934806a into main Jul 17, 2023
@cguedes cguedes deleted the 160-update-readme-with-demo-gif-and-information-about-project branch July 17, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update README with demo gif and information about project

3 participants