Skip to content

feat: frontend edit metadata for a single reference#280

Merged
cguedes merged 17 commits into
mainfrom
199-frontend-edit-metadata-for-a-single-reference
Jul 11, 2023
Merged

feat: frontend edit metadata for a single reference#280
cguedes merged 17 commits into
mainfrom
199-frontend-edit-metadata-for-a-single-reference

Conversation

@cguedes

@cguedes cguedes commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR fixes #199

Features implemented:

  • Edit selected reference fields:
    • citation key - basic text editor cell
    • title - basic text editor cell
    • authors - complex cell editor
    • published date - date field
  • Open references table in the LEFT
  • Improve logging for sidecar errors (Better communicate sidecar failure #277)
  • Notifications popup
    • Add expand/collapse button
    • Close button

Notes:

  • Maybe we can trigger an event to notify that the reference was edited (with changes), or at least when the cite key is updated)
    • This will allow components (ex: editor) to update the internal content (ex: citekey).

@cguedes cguedes linked an issue Jul 11, 2023 that may be closed by this pull request
[Frontend] Edit metadata for a single reference #199
Closed
cguedes
cguedes commented Jul 11, 2023
View reviewed changes
Comment thread .eslintrc.cjs
@cguedes cguedes marked this pull request as ready for review July 11, 2023 13:51
@cguedes cguedes requested a review from sehyod July 11, 2023 13:52
@codecov

codecov Bot commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #280 (a62bba4) into main (f30a45d) will decrease coverage by 0.19%.
The diff coverage is 81.96%.

❗ Current head a62bba4 differs from pull request most recent head e1c2d8e. Consider uploading reports for the commit e1c2d8e to get more accurate results

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   85.12%   84.94%   -0.19%     
==========================================
  Files         120      123       +3     
  Lines        6805     6994     +189     
  Branches      721      747      +26     
==========================================
+ Hits         5793     5941     +148     
- Misses        999     1040      +41     
  Partials       13       13
Impacted Files Coverage Δ
.../features/references/editor/grid/AuthorsEditor.tsx 20.40% <20.40%> (ø)
src/lib/autoFocusAndSelect.tsx 86.66% <60.00%> (-13.34%) ⬇️
...features/references/editor/ReferencesTableView.tsx 95.65% <83.33%> (-0.47%) ⬇️
src/api/ingestion.ts 100.00% <100.00%> (ø)
src/api/sidecar.ts 100.00% <100.00%> (ø)
src/atoms/editorActions.ts 97.61% <100.00%> (ø)
src/atoms/referencesState.ts 73.14% <100.00%> (+18.46%) ⬆️
...rc/features/references/editor/grid/ActionsCell.tsx 100.00% <100.00%> (ø)
src/features/references/editor/grid/StatusCell.tsx 100.00% <100.00%> (ø)
...c/notifications/footer/FooterNotificationItems.tsx 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sehyod
sehyod requested changes Jul 11, 2023
View reviewed changes
Comment thread src/api/__tests__/ingestion.update.test.ts Outdated
Comment thread src/api/ingestion.ts Outdated
Comment thread src/atoms/referencesState.ts Outdated
Comment thread src/atoms/referencesState.ts Outdated
@cguedes cguedes merged commit 38f63dd into main Jul 11, 2023
@cguedes cguedes deleted the 199-frontend-edit-metadata-for-a-single-reference branch July 11, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sehyod sehyod sehyod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Frontend] Edit metadata for a single reference

2 participants

@cguedes @sehyod