Skip to content

feat: add ability to remove one or all references (frontend)#248

Merged
cguedes merged 14 commits into
mainfrom
198-frontend-add-ability-to-remove-one-or-all-references
Jul 6, 2023
Merged

feat: add ability to remove one or all references (frontend)#248
cguedes merged 14 commits into
mainfrom
198-frontend-add-ability-to-remove-one-or-all-references

Conversation

@cguedes

@cguedes cguedes commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator

This PR allows the user to remove one or more references.

@cguedes cguedes linked an issue Jul 5, 2023 that may be closed by this pull request
@cguedes cguedes changed the title feat: frontend add ability to remove one or all references feat: add ability to remove one or all references (frontend) Jul 5, 2023
@cguedes cguedes marked this pull request as ready for review July 5, 2023 16:04
@cguedes cguedes requested a review from sehyod July 5, 2023 16:05
@codecov

codecov Bot commented Jul 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #248 (2c9cfc5) into main (574bbe3) will decrease coverage by 0.24%.
The diff coverage is 66.99%.

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   76.63%   76.40%   -0.24%     
==========================================
  Files         109      109              
  Lines        5732     5816      +84     
  Branches      515      521       +6     
==========================================
+ Hits         4393     4444      +51     
- Misses       1323     1356      +33     
  Partials       16       16              
Impacted Files Coverage Δ
src/atoms/referencesState.ts 54.68% <25.64%> (-45.32%) ⬇️
src/io/filesystem.ts 28.14% <66.66%> (+0.70%) ⬆️
...features/references/editor/ReferencesTableView.tsx 96.12% <78.57%> (-1.22%) ⬇️
src/api/ingestion.ts 100.00% <100.00%> (ø)
src/atoms/editorActions.ts 97.61% <100.00%> (-0.02%) ⬇️
src/events.ts 89.13% <100.00%> (+0.24%) ⬆️
...tures/references/components/ReferencesDropZone.tsx 100.00% <100.00%> (ø)
...c/features/references/components/TopActionIcon.tsx 100.00% <100.00%> (ø)
src/features/references/sidebar/ReferencesList.tsx 100.00% <100.00%> (ø)
...rc/features/references/sidebar/ReferencesPanel.tsx 98.36% <100.00%> (+0.07%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes marked this pull request as draft July 6, 2023 07:47
@cguedes cguedes marked this pull request as ready for review July 6, 2023 10:49
Comment thread src/atoms/referencesState.ts Outdated
Comment thread src/settings/SettingsModal.tsx Outdated
@cguedes cguedes merged commit 86d3ba1 into main Jul 6, 2023
@cguedes cguedes deleted the 198-frontend-add-ability-to-remove-one-or-all-references branch July 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Add ability to remove one or all references

2 participants