Skip to content

feat: add ability to delete file#243

Merged
cguedes merged 39 commits into
mainfrom
212-add-ability-to-delete-file
Jul 6, 2023
Merged

feat: add ability to delete file#243
cguedes merged 39 commits into
mainfrom
212-add-ability-to-delete-file

Conversation

@sehyod

@sehyod sehyod commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

This adds a context menu to files in the file explorer.
The menu has one action: Delete, that removes a file

Closes #212

@codecov

codecov Bot commented Jul 4, 2023

Copy link
Copy Markdown

Codecov Report

Merging #243 (e401e51) into main (b9e1e2d) will increase coverage by 8.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   76.63%   84.66%   +8.02%     
==========================================
  Files         106       12      -94     
  Lines        5522      652    -4870     
  Branches      489        0     -489     
==========================================
- Hits         4232      552    -3680     
+ Misses       1275      100    -1175     
+ Partials       15        0      -15     

see 94 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod force-pushed the 212-add-ability-to-delete-file branch from dcd922a to c39f0f4 Compare July 5, 2023 11:21
@sehyod sehyod marked this pull request as ready for review July 5, 2023 11:21
@sehyod sehyod marked this pull request as draft July 5, 2023 11:53
@sehyod sehyod marked this pull request as ready for review July 5, 2023 12:52
Comment thread src/application/App.tsx Outdated
Comment thread src/application/sidebar/fileExplorerContextMenu/fileExplorerContextMenu.css Outdated
Comment thread src/io/filesystem.ts Outdated
Comment thread src/settings/SettingsModal.tsx Outdated
@cguedes cguedes self-requested a review July 6, 2023 08:50
@cguedes cguedes merged commit 624af9e into main Jul 6, 2023
@cguedes cguedes deleted the 212-add-ability-to-delete-file branch July 6, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to delete files

2 participants