Skip to content

feat: references table view actions#240

Merged
cguedes merged 23 commits into
mainfrom
202-references_table_view_actions
Jul 5, 2023
Merged

feat: references table view actions#240
cguedes merged 23 commits into
mainfrom
202-references_table_view_actions

Conversation

@cguedes

@cguedes cguedes commented Jul 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This adds a data grid to view references with:

  • filtering (global, with any text)
  • column sort
  • column filter (hover on header and use widget)
  • column order
  • resizable coluns
  • pinned column (first with cite key)
  • custom cell render (for status)
  • selectable rows (SPACE or click in checkbox)
  • multiple rows selection (with range selection)
  • persistent column state (position, sort, visibility)
  • top action buttons
  • click on an author in References List (left panel) will open/update the references table with filter
  • initial support to edit references data (ex: title)
    • one can double-click in the title cell, but for now only displays action in the console

image

image

This closes #201

@codecov

codecov Bot commented Jul 2, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #240 (7f4a1cd) into main (7694137) will increase coverage by 1.38%.
The diff coverage is 96.28%.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   73.88%   75.27%   +1.38%     
==========================================
  Files         102      103       +1     
  Lines        5345     5370      +25     
  Branches      428      451      +23     
==========================================
+ Hits         3949     4042      +93     
+ Misses       1380     1313      -67     
+ Partials       16       15       -1
Impacted Files Coverage Δ
src/application/components/MainPanel.tsx 0.00% <0.00%> (ø)
...eferences/components/ReferencesItemStatusLabel.tsx 92.30% <92.30%> (ø)
...features/references/editor/ReferencesTableView.tsx 97.71% <97.51%> (-2.29%) ⬇️
src/atoms/editorActions.ts 100.00% <100.00%> (ø)
...c/features/references/components/TopActionIcon.tsx 100.00% <100.00%> (ø)
src/features/references/editor/ReferenceView.tsx 100.00% <100.00%> (+100.00%) ⬆️
...rc/features/references/editor/grid/columnsState.ts 100.00% <100.00%> (ø)
src/features/references/editor/grid/formatters.ts 100.00% <100.00%> (ø)
src/features/references/sidebar/ReferencesList.tsx 100.00% <100.00%> (+10.12%) ⬆️
...rc/features/references/sidebar/ReferencesPanel.tsx 98.29% <100.00%> (+18.29%) ⬆️
... and 3 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes changed the title 202 references table view actions feat: references table view actions Jul 3, 2023
@cguedes cguedes requested a review from sehyod July 4, 2023 16:34
@cguedes cguedes marked this pull request as ready for review July 4, 2023 16:34
sehyod
sehyod reviewed Jul 5, 2023
View reviewed changes
Comment thread src/application/components/MainPanel.tsx Outdated
Comment thread src/application/components/MainPanel.tsx Outdated
Comment thread src/atoms/types/EditorData.ts Outdated
Comment thread src/features/references/editor/ReferencesTableView.tsx
Comment thread src/features/references/editor/grid/__tests__/mockLocalStorage.ts
sehyod
sehyod previously approved these changes Jul 5, 2023
View reviewed changes
@cguedes cguedes merged commit 616974e into main Jul 5, 2023
@cguedes cguedes deleted the 202-references_table_view_actions branch July 5, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sehyod sehyod sehyod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

References "Table view" actions

2 participants

@cguedes @sehyod