Remove filename_md5 from backend#227
Merged
cguedes merged 2 commits intoJun 30, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 72.54% 72.52% -0.03%
==========================================
Files 103 103
Lines 5150 5146 -4
Branches 407 407
==========================================
- Hits 3736 3732 -4
Misses 1396 1396
Partials 18 18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
Collaborator
|
I have pushed the changes for the frontend:
|
cguedes
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #190
Discussed this with @cguedes and it makes more sense for us to consider the
source_filenameto be the true unique id of the Reference file, since that implicitly happens on the filesystem anyway.