Skip to content

feat: list view of references in sidebar#221

Merged
cguedes merged 17 commits into
mainfrom
202-list_view_of_references_in_sidebar
Jul 3, 2023
Merged

feat: list view of references in sidebar#221
cguedes merged 17 commits into
mainfrom
202-list_view_of_references_in_sidebar

Conversation

@cguedes

@cguedes cguedes commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator

This PR fixes #202

Notes:

  • The REMOVE action is still not implemented (would be implemented in [Frontend] Add ability to remove one or all references #198)
  • This PR stop saving the references to the local storage. Instead reads references from the backend on startup
  • You need to RESET all references and ingest again to use this new feature

image

@cguedes cguedes linked an issue Jun 29, 2023 that may be closed by this pull request
@cguedes cguedes requested a review from sehyod June 29, 2023 13:36
@codecov

codecov Bot commented Jun 29, 2023

Copy link
Copy Markdown

Codecov Report

Merging #221 (180ef39) into main (d0e1cf9) will increase coverage by 0.49%.
The diff coverage is 82.52%.

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   73.38%   73.88%   +0.49%     
==========================================
  Files         103      102       -1     
  Lines        5208     5345     +137     
  Branches      418      428      +10     
==========================================
+ Hits         3822     3949     +127     
- Misses       1368     1380      +12     
+ Partials       18       16       -2     
Impacted Files Coverage Δ
python/main.py 0.00% <0.00%> (ø)
python/sidecar/cli.py 0.00% <0.00%> (ø)
src/application/App.tsx 0.00% <0.00%> (ø)
src/application/sidebar/ExplorerPanel.tsx 0.00% <0.00%> (ø)
src/atoms/__tests__/test-utils.ts 100.00% <ø> (ø)
.../components/tipTapNodes/__tests__/test-fixtures.ts 100.00% <ø> (ø)
...tor/components/tipTapNodes/__tests__/test-utils.ts 100.00% <ø> (ø)
...rc/features/references/sidebar/ReferencesPanel.tsx 80.00% <68.57%> (-20.00%) ⬇️
src/features/references/sidebar/ReferencesList.tsx 89.87% <85.96%> (-10.13%) ⬇️
python/sidecar/ingest.py 90.29% <100.00%> (-1.59%) ⬇️
... and 11 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes changed the title 202 list view of references in sidebar feat: list view of references in sidebar Jul 3, 2023
Comment thread src-tauri/Cargo.toml Outdated
Comment thread src/io/filesystem.ts Outdated
Comment thread python/README.md Outdated
@cguedes cguedes merged commit 7694137 into main Jul 3, 2023
@cguedes cguedes deleted the 202-list_view_of_references_in_sidebar branch July 3, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"List view" of many references in left sidebar

2 participants