Skip to content

fix: always keep a file as active file when possible#206

Merged
cguedes merged 1 commit into
mainfrom
fix-split-panes
Jun 27, 2023
Merged

fix: always keep a file as active file when possible#206
cguedes merged 1 commit into
mainfrom
fix-split-panes

Conversation

@sehyod

@sehyod sehyod commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

Fixes #205

Removing the active file from a pane now updates the active file of the pane:

  • makes the last file of the pane the new active file
  • updates the field to undefined if there are no files left in the pane

@sehyod sehyod requested a review from cguedes June 27, 2023 13:25
@codecov

codecov Bot commented Jun 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #206 (99b3d38) into main (7f9cc08) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   70.94%   70.98%   +0.04%     
==========================================
  Files          94       94              
  Lines        4712     4719       +7     
  Branches      377      379       +2     
==========================================
+ Hits         3343     3350       +7     
  Misses       1352     1352              
  Partials       17       17              
Impacted Files Coverage Δ
src/atoms/core/paneGroup.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes merged commit c66f8dd into main Jun 27, 2023
@cguedes cguedes deleted the fix-split-panes branch June 27, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving a file from a pane to another does not properly the active file

2 participants