Skip to content

feat: improve file tree#196

Merged
cguedes merged 7 commits into
mainfrom
195-improve-file-tree
Jun 26, 2023
Merged

feat: improve file tree#196
cguedes merged 7 commits into
mainfrom
195-improve-file-tree

Conversation

@sehyod

@sehyod sehyod commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

This improves the File Tree component:

  • Hover and selected effects now take the whole width of pane
  • Open files use a FilesList component instead of FileTree
  • Directories are collapsible

Closes #195

@sehyod sehyod requested a review from cguedes June 26, 2023 10:44
@codecov

codecov Bot commented Jun 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #196 (b0043e2) into main (30cd1b5) will increase coverage by 0.64%.
The diff coverage is 76.34%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   66.91%   67.56%   +0.64%     
==========================================
  Files          87       89       +2     
  Lines        4498     4575      +77     
  Branches      331      338       +7     
==========================================
+ Hits         3010     3091      +81     
+ Misses       1471     1467       -4     
  Partials       17       17              
Impacted Files Coverage Δ
src/panels/ExplorerPanel.tsx 0.00% <0.00%> (ø)
src/panels/MainPanel.tsx 0.00% <0.00%> (ø)
src/atoms/core/paneGroup.ts 100.00% <100.00%> (ø)
src/components/FileEntryTree.tsx 100.00% <100.00%> (ø)
src/components/FileNode.tsx 100.00% <100.00%> (ø)
src/components/FilesList.tsx 100.00% <100.00%> (ø)
src/components/PanelSection.tsx 80.35% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod changed the title 195 improve file tree feat: improve file tree Jun 26, 2023
@cguedes

cguedes commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

image

Initial feedback by running the code:

  • The tree should only highlight the active file. I've opened a PDF and then closed it and it kept open
  • The items are very tight (vertically)
  • I also think that the highlight background is too strong (maybe we should use 100 instead of 200 slate)

cguedes

This comment was marked as outdated.

@cguedes cguedes self-requested a review June 26, 2023 16:07
@cguedes cguedes merged commit c896140 into main Jun 26, 2023
@cguedes cguedes deleted the 195-improve-file-tree branch June 26, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve file tree component

2 participants