fix: Fix regression issue with drag-drop in editor#192
Merged
Conversation
…ML events Also, adds tauri menu entry
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 66.91% 70.36% +3.44%
==========================================
Files 87 91 +4
Lines 4498 4592 +94
Branches 331 370 +39
==========================================
+ Hits 3010 3231 +221
+ Misses 1471 1344 -127
Partials 17 17
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
previously approved these changes
Jun 26, 2023
sehyod
left a comment
sehyod
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I let two comments, but nothing blocking.
While testing locally, I realised that you can still drag and drop a file on the title bar and it opens it with no way of getting out. It's very specific, I don't think it has to be fixed in this PR, but we should create a ticket for it to fix it later on.
sehyod
approved these changes
Jun 26, 2023
This was referenced Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload files feature broke the drag-drop of draggable elements in the TipTap editor!
References -> Upload...to open the upload files dialogrefstudio-pr-192.mov
NOTE: This PR don't aim to improve the left references sidebar.
This will close #173