Skip to content

feat: add reference viewer#180

Merged
cguedes merged 10 commits into
mainfrom
174-add-reference-viewer
Jun 22, 2023
Merged

feat: add reference viewer#180
cguedes merged 10 commits into
mainfrom
174-add-reference-viewer

Conversation

@sehyod

@sehyod sehyod commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

Fixes #174
This updates the atoms schema to enable opening anything with a name and an id (as opposed to only actual files with a filepath)
Clicking on a reference now opens it in the editor (in the right pane by default, like PDFs)
For now, the ReferenceViewer is a read-only table with reference data: citation key, title and authors list.

Screen.Recording.2023-06-22.at.10.02.28.mov

@codecov

codecov Bot commented Jun 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #180 (8a6ba61) into main (cb9c10f) will increase coverage by 1.94%.
The diff coverage is 59.10%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   63.25%   65.19%   +1.94%     
==========================================
  Files          82       84       +2     
  Lines        4022     4132     +110     
  Branches      285      305      +20     
==========================================
+ Hits         2544     2694     +150     
+ Misses       1457     1417      -40     
  Partials       21       21              
Impacted Files Coverage Δ
src/App.tsx 0.00% <0.00%> (ø)
src/atoms/core/activePane.ts 100.00% <ø> (ø)
src/editor/TipTapEditor.tsx 0.00% <0.00%> (ø)
src/panels/ExplorerPanel.tsx 0.00% <0.00%> (ø)
src/panels/MainPanel.tsx 0.00% <0.00%> (ø)
src/panels/ReferencesPanel.tsx 0.00% <ø> (ø)
src/views/ReferenceView.tsx 0.00% <0.00%> (ø)
src/views/TipTapView.tsx 0.00% <0.00%> (ø)
src/atoms/core/fileContent.ts 100.00% <100.00%> (ø)
src/atoms/core/fileData.ts 100.00% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod marked this pull request as ready for review June 22, 2023 09:03
@sehyod sehyod requested a review from cguedes June 22, 2023 09:03
@hammer

hammer commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

Nice! This provides an early implementation of the "reference detail view" mentioned in #159. When we tackle the "references table view" mentioned in that issue we may want to revisit the click target to be an icon or button rather than the whole reference row, but that's a small detail we can target later. Ultimately we'll want this reference detail view to support editing the metadata as well of course, and we may want to allow the authors to be clicked to search for references by that author, etc.

@sehyod

sehyod commented Jun 22, 2023

Copy link
Copy Markdown
Collaborator Author

Yes, you're right! This PR is the first step in having other things than files in the editor area.
We can definitely (and we probably will) add buttons to open either the pdf itself or the reference details view instead of having the click target being the whole row.
For the next features, like being able to click on an author name, I think we need to implement the references table view first, because we could then open this view with a filtering set to the author name

@cguedes cguedes merged commit 37d2718 into main Jun 22, 2023
@cguedes cguedes deleted the 174-add-reference-viewer branch June 22, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve click behaviour on references

3 participants