Codecov Report

Merging #179 (4f7d575) into main (37d2718) will increase coverage by 20.54%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #179       +/-   ##
===========================================
+ Coverage   65.19%   85.74%   +20.54%     
===========================================
  Files          84       11       -73     
  Lines        4132      435     -3697     
  Branches      305        0      -305     
===========================================
- Hits         2694      373     -2321     
+ Misses       1417       62     -1355     
+ Partials       21        0       -21     

see 72 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Nice! This PR definitely improves #118. Eventually we might want to do some kind of file type detection as I am able to drag any kind of file onto the app and get the upload behavior which is probably not the best user experience.

This PR does not address the first part of #173:

as the library grows, the upload target will move down the screen. Should we consider moving to a tabbed layout with "upload" as a tab next to "library"? Or some other solution?

In this PR, the text TIP: Click here or drag/drop PDF files here for upload. appears below the list of references and hence falls off the screen when there are many references. Perhaps when we do the references table view in #159 we can revisit how the system file browser is accessed and make it always visible?

For the ingestion status bar, if it's hard to communicate percent complete, I'm fine with just show that we're busy someplace. I guess we're going to have to figure out how to handle user actions that are taken while we are busing with the ingestion process. We certainly don't want to block the whole app, but perhaps we want to block new uploads until the previous uploads finish?

Nice! This PR definitely improves #118. Eventually we might want to do some kind of file type detection as I am able to drag any kind of file onto the app and get the upload behavior which is probably not the best user experience.

Sure. That's fixed.

In this PR, the text TIP: Click here or drag/drop PDF files here for upload. appears below the list of references and hence falls off the screen when there are many references.

My idea, for the MVP, was that they would see this information when the references list is empty. So they will learn how to upload (click or drag-drop). I agree that we should add a menu entry for References -> Upload and also some other indicator (icon) in the panel for the upload action.

For the ingestion status bar, if it's hard to communicate percent complete, I'm fine with just show that we're busy someplace.

Yes, the idea was to show that we are busy. The %age isn't even working as we don't have that information (we will have after #178).

I guess we're going to have to figure out how to handle user actions that are taken while we are busing with the ingestion process. We certainly don't want to block the whole app, but perhaps we want to block new uploads until the previous uploads finish?

Sure. I decided that for now we won't block them from upload/ingest concurrently but def improve this after that backend part is improved. Also, for the "busy indicator" maybe we should build a fixed bottom bar like VS Code has for loading indicators.