feat: Add ingestion status for References#178
Closed
gjreda wants to merge 5 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 63.25% 60.52% -2.73%
==========================================
Files 82 71 -11
Lines 4022 3587 -435
Branches 285 285
==========================================
- Hits 2544 2171 -373
+ Misses 1457 1395 -62
Partials 21 21 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
reviewed
Jun 21, 2023
Comment on lines
+136
to
+137
| Determines which files need to be ingested by comparing the list of | ||
| already processed References against files found in `uploads`. |
Collaborator
There was a problem hiding this comment.
Wouldn't be easier to give you the list of file paths to ingest? In the FE the user selects files and not directories.
| "type": "string" | ||
| }, | ||
| "status": { | ||
| "type": "string" |
Collaborator
There was a problem hiding this comment.
Can we have a enum here (i.e. expected strings for status)?
|
|
||
| logger.addHandler(handler) | ||
| logger.disabled = os.environ.get("SIDECAR_ENABLE_LOGGING", "false").lower() == "true" | ||
| logger.disabled = os.environ.get("SIDECAR_DISABLE_LOGGING", "true").lower() == "true" |
Collaborator
There was a problem hiding this comment.
Do you want to make logging active by default?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a WIP for now. Need to fix one bug and add/update tests.
part of #113
This PR updates ingest to:
uploadsand work from a.stagingdirectory so that each new upload does not process previously ingested Referencesstatusfield toReferencewhich displays the "completed" ingestion status