Switch from dataclasses-jsonschema to Pydantic#146
Merged
Conversation
danvk
approved these changes
Jun 15, 2023
| export type Text1 = string; | ||
| export type Rewrite = RewriteChoice[]; | ||
| export type Index1 = number; | ||
| export type Text2 = string; |
Collaborator
There was a problem hiding this comment.
This isn't great — it's certainly not how you'd write the TypeScript types if you were writing them by hand. But it's not wrong, and we can work with it.
Collaborator
Author
There was a problem hiding this comment.
I just noticed this as well. I'm happy to change field names here on my end if it'd make the TS side nicer for y'all.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #136
This is a WIP. Figured we might as well do it now when we don't have many types as it seems fairly straightforward.