Revert "feat: pull Python types into TypeScript (#126)"#135
Closed
gjreda wants to merge 1 commit into
Closed
Conversation
This reverts commit 6c02266.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6c02266.
Reverting this because it's spitting errors that are unclear and is preventing me from pushing up changes. Since this PR is not a "must have" right now and @danvk spends Thursdays on this project, I didn't want to be blocked on pushing changes for several days.
It's also quite possible I'm doing something wrong here.
Here is what happened when I first tried to push my changes, with all tests for both JS and python passing:
Details
It wasn't obvious to me what the actual error was, so I committed the generated schemas and tried to push again, which resulted in the below: