Skip to content

POC using Lexical Editor#13

Closed
cguedes wants to merge 29 commits into
refstudio:mainfrom
cguedes:poc-editor-lexical
Closed

POC using Lexical Editor#13
cguedes wants to merge 29 commits into
refstudio:mainfrom
cguedes:poc-editor-lexical

Conversation

@cguedes

@cguedes cguedes commented May 16, 2023

Copy link
Copy Markdown
Collaborator

This PR is the POC for using Lexical within the evaluation of text editors being discussed in #4

POC with 3 panels:

  • Left Panel: References list
  • Center Panel: Lexical editor with rich-text
  • Right Panel : AI interactions

Selections of text are listed in the right panel, and clicks on a reference (left panel) add the text (ex: Ref 3) to the selected/cursor area in the editor (central panel).

image

@cguedes cguedes changed the title Handle references click via left sidebar POC using Lexical Editor May 16, 2023
Comment thread index.html Outdated
@cguedes cguedes marked this pull request as draft May 17, 2023 07:56
@hammer

hammer commented May 17, 2023

Copy link
Copy Markdown
Contributor

Hey small development process that I like to follow: I prefer to have an issue open before a PR is opened. @cguedes could you open an issue for a Lexical prototype so that we can discuss high-level thoughts there and code-level thoughts here in the PR?

@cguedes

cguedes commented May 17, 2023

Copy link
Copy Markdown
Collaborator Author

@hammer do you think we should link to #4 or create a specific issue for Lexical linked to #4?

@hammer

hammer commented May 17, 2023

Copy link
Copy Markdown
Contributor

Up to you!

@danvk

danvk commented May 18, 2023

Copy link
Copy Markdown
Collaborator

Another small point on development process: it'll be easier for everyone if we create branches on this repo (rather than a fork) for PRs. I think everyone should have push rights? Or can easily be given them.

@hammer

hammer commented May 18, 2023

Copy link
Copy Markdown
Contributor

Wow a lot of features already implemented! A few thoughts:

  • We can resize components now. How easy is it to collapse them entirely, or re-arrange them?
  • What is the difference between "Uploads" and "References"? Do we want them to be separate?
  • If we wanted to have multiple documents, is it easy to add them as tabs as in VS Code? Long term this creates questions about the scope of references and AI interactions. Nothing happens if I click "file2.txt", e.g.
  • ">" to create a collapsible block behaves weirdly
  • "Markdown" toggle does not seem to be able to toggle back.
  • Inserting references already, nice! It would be nice to be able to insert from Markdown using the appropriate syntax.
  • Vertical alignment of Lexical toolbar is odd, it's covered by the title bar and doesn't show fully even in fll screen mode.

@hammer hammer mentioned this pull request May 18, 2023
@cguedes

cguedes commented May 22, 2023

Copy link
Copy Markdown
Collaborator Author

Closing this in favor of #23 that integrates Lexical using the most recent codebase.

@cguedes cguedes closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants